Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netty-tcnative included in shaded jar causes problem with mixed netty versions #1778

Open
flozano opened this issue Jul 21, 2023 · 0 comments

Comments

@flozano
Copy link

flozano commented Jul 21, 2023

Describe the issue
The issue is that netty-tcnative can not be effectively shaded, but it's being included in the shaded jar.

./META-INF/native/libnetty_tcnative_linux_x86_64.so
./META-INF/native/libnetty_tcnative_osx_aarch_64.jnilib
./META-INF/native/netty_tcnative_windows_x86_64.dll
./META-INF/native/libnetty_tcnative_linux_aarch_64.so
./META-INF/native/libnetty_tcnative_osx_x86_64.jnilib

those native/* libs are causing trouble when mixing netty versions.

What you are trying to do
I'm trying to move from using the mockserver-netty dependency to the mockserver-netty-no-dependencies artifact, so that I can upgrade libraries (eg: json-unit to 3.0.0) without causing trouble to mockserver itself.

MockServer version
5.15.0

To Reproduce
use a newer netty-tcnative version together with mockserver-netty-no-dependencies.

  1. Running as JUnit with manual instantiation

Expected behaviour
I would expect netty-tcnative not to be included in the shaded jar, nor any other native lib, as those cannot be shaded properly the same as other JARs (not sure if there are different techniques to relocate such resources...).

netty is a very common dependency, and it will be a common case unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant