creates two dependencies for one "new" instruction

[NicolasAnquetil]

take this instruction: new Environnement(graph)

it results in an invocation of the constructor Environnement() + a reference to the type Environnement

So one new results in two dependencies :-(

[NicolasAnquetil]

Actually, 2 references and one invocation were created for each 'new' !
previous commit removed 1 reference, but there is still another one (+ the invocation)

[NicolasAnquetil]

Analyzing:

• SomeType var = new SomeType(): the new was creating 1 Reference and has been corrected by previous commit
• someMethod( new SomeType()): was creating 2 References and only one was corrected

[NicolasAnquetil]

Re-opening the issue: What association should we create from an instanciation?

Is it:

• one dependency: the Reference to the class name
• one dependency: the Invocation of the constructor (possibly, the implicit default constructor)
• two dependencies: Reference + Invocation

It is worth remembering that in Pharo, we can only create one dependency from AClass new because it would be too difficult to pinpoint all message sends that can end up in calling the instantiate method (the constructor): new could be redefined ; other class side methods could also call instantiate

So do we rollback the change in VerveineJ (considering only the Invocation)?

[badetitou]

Hello

In my opinion, we should have only the invocation (and not the class reference).
new Blabla() is like a method call. Maybe the declaredType should be Blabla

class reference is for cases such as BlaBla.myVariable