-
Notifications
You must be signed in to change notification settings - Fork 18
Control characters in serial number when retrieving specific USB memory information on Windows/Linux #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I suspected that CP932 might be affecting the issue due to the Japanese locale of my PowerShell execution environment. However, I changed the encoding to UTF-8 and re-tested, but the result remained the same |
Thank you for posting about this. Note that the focus of this research is on internal components. And in the near future, paccor will be updated to collect disk information according to the TCG Storage Component Class Registry. It leaves out USB devices at the moment. I'll still have a method to query the scripts. Are you able to tell what actual values are being reported by your USB devices? I can see a problem in an assumption that I make in my Linux script that filters text data retrieved from lshw. It only returns a selection of ASCII characters Does lshw output the correct data for those devices? I'm thinking the Windows allcomponents script is accurately saving the data returned by the powershell get-physicaldisk command. Especially after reading point 1 in your post under additional context. I've had to implement plenty of special processing choices in these scripts. So have others working in this space. That's part of the reason for the newer component class registries. Some changes I could make for you in these scripts: And I can make sure I'm not filtering valid UTF8 characters on the Linux side. That should allow the UTF8 characters in the serial on the Buffalo device to be collected on Linux. What do you think? |
Thank you for your prompt and detailed response, including your proposed solutions. Regarding the TCG Storage Component Class Registry, I have verified your point that USB mass storage devices are not currently included. Considering their occasional use in server environments, their inclusion could indeed be valuable. As our organization is a TCG member, I will bring this up for discussion with the TCG Infrastructure Work Group. As requested, I have attached the output from the
Thank you again for investigating this issue. Please let me know if any further information or testing is required from my end. |
Is there any indication where Windows got the serialnumber values it reported for your disks? Both powershell and lshw reported the iManufacturer and iProduct values as manufacturer and model for both USB chassis. iSerialNumber is present for both, but not reported as the disk serial number. Does using the -json option in lshw change the output of the serial number? |
Description
When retrieving information for specific USB memory devices using paccor v1.1.4r11 (Windows), control characters are included in the serial number.
Affected USB Memory Devices
Steps to Reproduce
Expected behavior
The serial number should be displayed correctly without any control characters.
Actual behavior
Control characters are included in the serial number.
Example
JSON
Additional context
Get-PhysicalDisk | select serialnumber,mediatype,manufacturer,model,bustype | where BusType -ne NVMe
paccor_result_linux_kingston.txt
paccor_result_linux_buffalo.txt
paccor_result_windows.txt
The text was updated successfully, but these errors were encountered: