Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value for COMMUTER_S3_ENDPOINT shouldn't be an empty string #298

Open
elvinx opened this issue Jun 23, 2020 · 1 comment
Open

Default value for COMMUTER_S3_ENDPOINT shouldn't be an empty string #298

elvinx opened this issue Jun 23, 2020 · 1 comment

Comments

@elvinx
Copy link

elvinx commented Jun 23, 2020

I am trying to use commuter with s3 and if I don't set COMMUTER_S3_ENDPOINT the default is

var s3Endpoint = env.COMMUTER_S3_ENDPOINT || ""

this causes

rror: connect ECONNREFUSED 127.0.0.1:443
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1129:14) {
  message: 'connect ECONNREFUSED 127.0.0.1:443',
  errno: -61,
  code: 'NetworkingError',
  syscall: 'connect',
  address: '127.0.0.1',
  port: 443,
  region: 'us-east-1',
  hostname: '',
  retryable: true,
  time: 2020-06-23T10:28:51.483Z
} Error: connect ECONNREFUSED 127.0.0.1:443
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1129:14)

However it works fine if it is set to null.

@captainsafia
Copy link
Member

Thanks for reporting this issue, @elvinx!

Would you like to submit a pull request with a fix for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants