Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: a11y rule "interactive-supports-focus" fails with a warning. #4138

Open
Tracked by #4139
FatumaA opened this issue Sep 26, 2024 · 2 comments · May be fixed by #4159
Open
Tracked by #4139

enhancement: a11y rule "interactive-supports-focus" fails with a warning. #4138

FatumaA opened this issue Sep 26, 2024 · 2 comments · May be fixed by #4159
Assignees
Labels
a11y Issues related to accessibility 🐛 bug Something isn't working hacktoberfest Issues for https://hacktoberfest.digitalocean.com/

Comments

@FatumaA
Copy link
Contributor

FatumaA commented Sep 26, 2024

Describe the bug

jsx-a11y eslint plugin was recently added to the project and this rule -jsx-a11y/interactive-supports-focus - fails with a warning.

This issue offers more context: #2264

Steps to reproduce

The following components and files are causing the rule to fail:

  1. components/TabList/tab-list.tsx
@FatumaA FatumaA added 🐛 bug Something isn't working 👀 needs triage labels Sep 26, 2024
Copy link
Contributor

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please comment on this issue.

For full info on how to contribute, please check out our contributors guide.

@nickytonline nickytonline added hacktoberfest Issues for https://hacktoberfest.digitalocean.com/ a11y Issues related to accessibility and removed 👀 needs triage labels Oct 1, 2024
@Bashamega
Copy link
Contributor

.take

Bashamega added a commit to Bashamega/app that referenced this issue Oct 11, 2024
…supports-focus" warning

The changes include adding tabIndex={0} to elements with role="tab" to ensure they are focusable for
keyboard navigation, addressing the accessibility warning (jsx-a11y/interactive-supports-focus).
Additionally, an onKeyDown handler was introduced to allow keyboard interaction, enabling users to
select tabs using the Enter or Space keys. These changes improve both accessibility and user
experience by making the tabs keyboard-accessible.

fixes open-sauced#4138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Issues related to accessibility 🐛 bug Something isn't working hacktoberfest Issues for https://hacktoberfest.digitalocean.com/
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants