refactor: replace Split in loops with more efficient SplitSeq

findnature · findnature · commit 12276776ea74 · 2025-05-02T14:59:33.000+08:00
Signed-off-by: findnature &lt;cricis@aliyun.com&gt;
diff --git a/v2/pkg/testutils/integration.go b/v2/pkg/testutils/integration.go
@@ -27,8 +27,8 @@ func RunSubfinderAndGetResults(debug bool, domain string, extra ...string) ([]st
 		return nil, err
 	}
 	var parts []string
-	items := strings.Split(string(data), "\n")
-	for _, i := range items {
+	items := strings.SplitSeq(string(data), "\n")
+	for i := range items {
 		if i != "" {
 			parts = append(parts, i)
 		}

Original file line number	Diff line number	Diff line change
`@@ -27,8 +27,8 @@ func RunSubfinderAndGetResults(debug bool, domain string, extra ...string) ([]st`
`27`	`27`	`return nil, err`
`28`	`28`	`}`
`29`	`29`	`var parts []string`
`30`		`- items := strings.Split(string(data), "\n")`
`31`		`- for _, i := range items {`
	`30`	`+ items := strings.SplitSeq(string(data), "\n")`
	`31`	`+ for i := range items {`
`32`	`32`	`if i != "" {`
`33`	`33`	`parts = append(parts, i)`
`34`	`34`	`}`