Skip to content

Log config to output only on rank zero #2700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
joecummings opened this issue May 8, 2025 · 0 comments
Open

Log config to output only on rank zero #2700

joecummings opened this issue May 8, 2025 · 0 comments
Labels
best practice Things we should be doing but aren't community help wanted We would love the community's help completing this issue good first issue Good for newcomers

Comments

@joecummings
Copy link
Contributor

Currently, we call config.log_config in the recipe_main which means this logs to every device.

We really only need this to happen once. See callsite here:

torchtune/recipes/full_finetune_distributed.py

Line 1093 in dd67641

config.log_config(recipe_name="FullFinetuneRecipeDistributed", cfg=cfg)

@joecummings joecummings added good first issue Good for newcomers best practice Things we should be doing but aren't community help wanted We would love the community's help completing this issue labels May 8, 2025
@kabir2505 kabir2505 mentioned this issue May 9, 2025
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
best practice Things we should be doing but aren't community help wanted We would love the community's help completing this issue good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joecummings