Skip to content

[BUG] Empty result error from wikidata query #2226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 tasks
SimonYansenZhao opened this issue Apr 26, 2025 · 3 comments
Open
3 tasks

[BUG] Empty result error from wikidata query #2226

SimonYansenZhao opened this issue Apr 26, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@SimonYansenZhao
Copy link
Collaborator

SimonYansenZhao commented Apr 26, 2025

Description

The error is from running the tests in tests/data_validation/examples/test_wikidata.py::test_wikidata_runs and tests/data_validation/examples/test_wikidata.py::test_wikidata_values which run the notebook examples/01_prepare_data/wikidata_knowledge_graph.ipynb. When results_list is empty, we will get the error.

Screenshot 2025-04-26 at 09 50 02

And the same issue occurs in the following code as well when result is empty.

Screenshot 2025-04-26 at 09 59 29

In which platform does it happen?

How do we replicate the issue?

Create a GitHub Codespace, and run the notebook examples/01_prepare_data/wikidata_knowledge_graph.ipynb multiple times until results_list is empty.

Image

Or run it locally by the following steps:

  1. Setup

    cd recommenders
    conda create -n reco python=3.11
    conda activate reco
    pip install .[dev]
    
  2. Run the examples/01_prepare_data/wikidata_knowledge_graph.ipynb in VS Code multiple times until results_list is empty.

Expected behavior (i.e. solution)

results_list and result in the notebook examples/01_prepare_data/wikidata_knowledge_graph.ipynb should not be empty.

Willingness to contribute

  • Yes, I can contribute for this issue independently.
  • Yes, I can contribute for this issue with guidance from Recommenders community.
  • No, I cannot contribute at this time.

Other Comments

@miguelgfierro
Copy link
Collaborator

related to #2210

@miguelgfierro
Copy link
Collaborator

@SimonYansenZhao I'm trying to improve the wikidata notebook

@miguelgfierro
Copy link
Collaborator

the PR would not solve the issue because it is due to a rate limit of the wikidata API, but at least we have more visibility on it. We just need to retry the test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants