Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instability around fixtures that add environment variables to MCG's pods #11320

Open
sagihirshfeld opened this issue Feb 9, 2025 · 0 comments · May be fixed by #11321
Open

Instability around fixtures that add environment variables to MCG's pods #11320

sagihirshfeld opened this issue Feb 9, 2025 · 0 comments · May be fixed by #11321
Assignees
Labels
MCG Multi Cloud Gateway / NooBaa related issues Squad/Magenta Squad/Red

Comments

@sagihirshfeld
Copy link
Contributor

add_env_vars_to_noobaa_core_fixture and add_env_vars_to_noobaa_endpoint_fixture are patching a STS/Deployment, then resets and waits for the relevant pod to restart.

There are two issues with this:

  1. Patching the STS/Deployment triggers the restart of the pods by itself, so the following manual restart is redundant.
  2. The health check is implicit in the method that resets the pods, and sometimes incomplete. This caused multiple race conditions already in our pipeline.
@sagihirshfeld sagihirshfeld added MCG Multi Cloud Gateway / NooBaa related issues Squad/Magenta Squad/Red labels Feb 9, 2025
@sagihirshfeld sagihirshfeld self-assigned this Feb 9, 2025
@sagihirshfeld sagihirshfeld linked a pull request Feb 9, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MCG Multi Cloud Gateway / NooBaa related issues Squad/Magenta Squad/Red
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant