Bug in endedReserves

[robertogallea]

Hi @shayan-yousefi !

The current implementation has a bug in the loading of endedReserves. Indeed, the current code

    public function endedReserves(): MorphMany
    {
        return $this->reserves()->whereDate('end_reserve_date', '<', now())->orWhere(function ($query) {
            $query->whereDate('end_reserve_date', '=', now())->whereTime('end_reserve_time', '<=', now());
        })->with(['customer', 'reservable']);
    }

produces the query

SELECT *
FROM   `reserves`
WHERE  `reserves`.`customer_type` = ?
       AND `reserves`.`customer_id` = ?
       AND `reserves`.`customer_id` IS NOT NULL
       AND Date(`end_reserve_date`) < ?
        OR ( Date(`end_reserve_date`) = ?
             AND Time(`end_reserve_time`) <= ? ) 

which is wrong (it loads today reserves with past time without regards of any other condition.

The correct query should be

SELECT *
FROM   `reserves`
WHERE  `reserves`.`customer_type` = ?
       AND `reserves`.`customer_id` = ?
       AND `reserves`.`customer_id` IS NOT NULL
       AND ( Date(`end_reserve_date`) < ?
              OR ( Date(`end_reserve_date`) = ?
                   AND Time(`end_reserve_time`) <= ? ) ) 

I'm making a PR which solves the issue.

Thank you.