Skip to content

Does order of treatment/control group matter for esc_mean_gain function? #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mihaylova1 opened this issue Feb 12, 2020 · 8 comments

Comments

@Mihaylova1
Copy link

Hi Daniel & all,

Does anyone know whether group1 should always be treatment group and group2 as control? For some functions like convert_d2r and esc_B, it is stipulated to enter experimental group values as group 1 and control group as group 2. However, for functions like esc_mean_sd and esc_mean_gain, this is not stipulated.

I've been using the function esc_mean_gain entering treatment group as group1 and getting opposite results from what is anticipated. Just wondering whether there is a necessary order for these two functions and what computations they are doing to obtain the result?

Thank you for your input

@strengejacke
Copy link
Owner

Could you provide a small reproducible example (maybe also with desired results/output)?

@Mihaylova1
Copy link
Author

Mihaylova1 commented Feb 12, 2020 via email

@Mihaylova1
Copy link
Author

Mihaylova1 commented Feb 13, 2020 via email

@strengejacke
Copy link
Owner

Not yet, but I'll look into this the next days.

@Mihaylova1
Copy link
Author

Mihaylova1 commented Feb 13, 2020 via email

@Mihaylova1
Copy link
Author

Mihaylova1 commented Feb 19, 2020 via email

@poschfeld
Copy link

poschfeld commented Jan 3, 2022

Hi @strengejacke,

following up on this question in the context of transforming an F-Test using esc_f. Obviously, the output includes a positive effect size and CI, although from reading the original study we know it should be negative. Is there a way to automatically label the esc_f calculation for direction, without manually inverting ES and CI values?

Many thanks for the awesome package btw, found it through the Harrer et al. (2021) guide and really appreciate how straight forward it is!

All the best,
Poul

@linneagandhi
Copy link

linneagandhi commented Jun 5, 2024

Hi @strengejacke and @Mihaylova1
I'm also having issues with this function esc_mean_gain -- looking into the source code, I believe that there may be an error:

See lines 161-163
compute mean gain scores for groups 1 and 2
if (missing(gain1mean)) gain1mean <- pre1mean - post1mean
if (missing(gain2mean)) gain2mean <- pre2mean - post2mean

I would have expected this to read: post-pre not pre-post. That would explain why @Mihaylova1 your results seemed flipped (and why my own seem flipped as well in using the code today :-)

If the developer team is busy and @Mihaylova1 you are still working on the project, you could just reverse the sign manually or edit the source code that is locally stored on your computer. (Assuming my diagnosis is right of course!) Happy to be corrected if I'm missing something!
~Linnea Gandhi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants