Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUP spams logs with useless errors "unknown protocol" #472

Closed
asolntsev opened this issue Feb 7, 2025 · 1 comment
Closed

BUP spams logs with useless errors "unknown protocol" #472

asolntsev opened this issue Feb 7, 2025 · 1 comment
Milestone
3.1.1

Comments

@asolntsev
Copy link

asolntsev commented Feb 7, 2025 •
edited
Loading

Describe the bug

  • java.net.MalformedURLException: unknown protocol: accounts.google.com
  • java.net.MalformedURLException: unknown protocol: googlechromelabs.github.io
  • java.net.MalformedURLException: unknown protocol: safebrowsingohttpgateway.googleapis.com
  • java.net.MalformedURLException: unknown protocol: plausible.io
  • java.net.MalformedURLException: no protocol: 127.0.0.1:36915

To Reproduce
Steps to reproduce the behavior: clone Selenide project and run test integration.proxy.ChainedProxyTest.

Expected behaviour

  1. BUP doesn't spam logs
  2. BUP doesn't even try to parse URLs if
  3. BUP handles hostnames like

Please complete the following information:

  • OS: MacOS Sequioia 15.3
  • Browser: Chrome 133.0.6943.54
  • BUP version: 3.1.0

Stack trace

19:04:11:414 [LittleProxy-1-ClientToProxyWorker-1] ERROR BrowserUpProxyServer - The requested URL is not valid.
java.net.MalformedURLException: unknown protocol: accounts.google.com
	at java.base/java.net.URL.<init>(URL.java:681)
	at java.base/java.net.URL.<init>(URL.java:569)
	at java.base/java.net.URL.<init>(URL.java:516)
	at com.browserup.bup.BrowserUpProxyServer.lambda$start$1(BrowserUpProxyServer.java:426)
	at org.littleshoot.proxy.impl.ProxyToServerConnection.create(ProxyToServerConnection.java:206)
	at org.littleshoot.proxy.impl.ClientToProxyConnection.doReadHTTPInitial(ClientToProxyConnection.java:317)
	at org.littleshoot.proxy.impl.ClientToProxyConnection.readHTTPInitial(ClientToProxyConnection.java:236)
	at org.littleshoot.proxy.impl.ClientToProxyConnection.readHTTPInitial(ClientToProxyConnection.java:95)
	at org.littleshoot.proxy.impl.ProxyConnection.readHTTP(ProxyConnection.java:151)
	at org.littleshoot.proxy.impl.ProxyConnection.read(ProxyConnection.java:127)
	at org.littleshoot.proxy.impl.ProxyConnection.channelRead0(ProxyConnection.java:570)
	at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:99)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420)
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412)
	at io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:289)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:442)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420)
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412)
	at io.netty.channel.ChannelInboundHandlerAdapter.channelRead(ChannelInboundHandlerAdapter.java:93)
	at org.littleshoot.proxy.impl.ProxyConnection$RequestReadMonitor.channelRead(ProxyConnection.java:703)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420)
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412)
	at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:107)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420)
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412)
	at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:107)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420)
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412)
	at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:346)
	at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:318)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420)
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412)
	at io.netty.channel.ChannelInboundHandlerAdapter.channelRead(ChannelInboundHandlerAdapter.java:93)
	at org.littleshoot.proxy.impl.ProxyConnection$BytesReadMonitor.channelRead(ProxyConnection.java:680)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420)
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412)
	at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1357)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:440)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420)
	at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:868)
	at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:166)
	at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:788)
	at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:724)
	at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:650)
	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:562)
	at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997)
	at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
	at java.base/java.lang.Thread.run(Thread.java:840)
asolntsev added a commit to asolntsev/browserup-proxy that referenced this issue Feb 7, 2025
@asolntsev
valfirst#472 refactor: extract a code snippet to a method `isNonProxy…
560048c 
…Host()`

I made it package-private to call from a unit-test.
asolntsev added a commit to asolntsev/browserup-proxy that referenced this issue Feb 7, 2025
@asolntsev
valfirst#472 fix: make "foo-example.com" NOT match "*.example.com"
6beff3a
asolntsev added a commit to asolntsev/browserup-proxy that referenced this issue Feb 7, 2025
@asolntsev
valfirst#472 fix: support "accounts.google.com:443" in addition to "h…
f513254 
…ttps://accounts.google.com"
@asolntsev asolntsev mentioned this issue Feb 7, 2025
Merged
valfirst pushed a commit that referenced this issue Feb 8, 2025
@asolntsev @valfirst
#472 refactor: extract a code snippet to a method isNonProxyHost()
ed6e059 
I made it package-private to call from a unit-test.
valfirst pushed a commit that referenced this issue Feb 8, 2025
@asolntsev @valfirst
#472 fix: make "foo-example.com" NOT match "*.example.com"
6f4b60d
valfirst pushed a commit that referenced this issue Feb 8, 2025
@asolntsev @valfirst
#472 fix: support "accounts.google.com:443" in addition to "https://a…
4e78ac1 
…ccounts.google.com"
@valfirst
Copy link
Owner

valfirst commented Feb 8, 2025

Fixed by #473

@valfirst valfirst closed this as completed Feb 8, 2025
@valfirst valfirst added this to the 3.1.1 milestone Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.1
Development

No branches or pull requests
2 participants
@asolntsev @valfirst