Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "hasTouch" argument for "browsingContext.setViewport" command #773

Open
whimboo opened this issue Sep 13, 2024 · 0 comments
Labels
enhancement New feature or request module-browsingContext Browsing Context module needs-discussion Issues to be discussed by the working group

Comments

@whimboo
Copy link
Contributor

whimboo commented Sep 13, 2024

Both Puppeteer and Playwright support an hasTouch boolean argument for the setViewport command, which is currently missing in WebDriver BiDi. We should add support for this parameter with the following behavior:

  • Default Behavior: By default isTouch is set to false, meaning touch events are not enabled.

  • Touch enabled: When hasTouch is set to true, touch events are enabled, allowing interactions like swiping and tapping. This argument is independent from isMobile and allows to use touch emulation on desktop-like environments with touch capabilities (as with touch-enabled laptops or tablets).

Question: We currently support touch events in input.performActions by default. How should these behave when hasTouch is disabled? Should we consider disallowing their use in this case?

@whimboo whimboo added enhancement New feature or request module-browsingContext Browsing Context module needs-discussion Issues to be discussed by the working group labels Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module-browsingContext Browsing Context module needs-discussion Issues to be discussed by the working group
Projects
None yet
Development

No branches or pull requests

1 participant