Skip to content

Add support for elk docker container environment variables #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jessebot
Copy link
Contributor

@jessebot jessebot commented Mar 1, 2025

I think these are the only env vars that really matter for someone who wants the base functionality of elk. The only one that is default set is NUXT_STORAGE_DRIVER which is default set in the container to fs.

I also made sure to support someone using their own k8s secret to make sure any future env vars are easy to add before we fully support them here. To see a full list of env vars that may or may not work (this is alpha software afterall), check out elk-zone/elk:.env.example

These are all the values I've added:

elk:
  # existing Kubernetes Secret to use for elk docker container environment variables
  # if set, ignores everything under elk.env
  existingEnvSecret: ""
  # ignored if elk.existingEnvSecret is set
  env:
    # public translate api endpoint
    public_translate_api: ""
    # default instance to load feeds from when a user goes to this elk frontend
    public_default_server: ""
    public_single_instance: ""

    # administration key
    admin_key: ""

This PR is in a draft state till I can test it locally, but wanted to get something out there sooner than later.

Kind regards and let me know if there's anything you'd like to improve here 🙏

@jessebot
Copy link
Contributor Author

jessebot commented Mar 1, 2025

I got the container up and running, and it lets me login, but it's not taking my NUXT_PUBLIC_DEFAULT_SERVER env var, for instance. NUXT_PUBLIC_DEFAULT_SERVER is present when I kubectl exec -it NAME_OF_ELK_POD -- /bin/sh and then run env, so I know it makes it into the container, but it doesn't then set the default instance at all 🤔 I also don't know how to view logs, so I opened up this issue for the docs upstream:

elk-zone/elk#3219

@0hlov3
Copy link
Owner

0hlov3 commented Mar 3, 2025

Hi there,

sorry had time at the weekend to look into it, I`ll try to get this merged later. :)

@0hlov3
Copy link
Owner

0hlov3 commented Mar 4, 2025

Sorry again, I'll check it out today! :)

@0hlov3 0hlov3 self-assigned this Mar 7, 2025
@0hlov3
Copy link
Owner

0hlov3 commented Mar 7, 2025

@jessebot I'm having a bit of trouble understanding the Netlify integration. Could you please clarify how it's supposed to work? Let me know if we can merge this as is or if additional changes are needed.

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants