-
Notifications
You must be signed in to change notification settings - Fork 820
Boost Page Cache: make module off when Endurance Page Cache is on #43416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Fixes HOG-96 When a site already uses the Endurance Page Cache service, and that service is active on the site, we should not offer the option to turn on Boost's page cache.
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Boost plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 2 files.
2 files are newly checked for coverage.
Full summary · PHP report · JS report If appropriate, add one of these labels to override the failing coverage check:
Covered by non-unit tests
|
So far only using the filter, since the Endurance_Page_Cache class doesn't exist in our codebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, thanks for taking care of this and including tests!
It's ready for a merge.
When I saw the notice that Page Cache is unavailable, I recalled a conversation about users on WoA being unable to activate Boost's cache. As a result, we ended up updating the UI to this:
I wonder if it makes sense to update the current notice to be in the same style, but say "your hosting" instead of "WordPress.com". If we do, we can do it in a follow up. I just wanted your thoughts on this.
Fixes HOG-96
Proposed changes:
When a site already uses the Endurance Page Cache service, and that service is active on the site, we should not offer the option to turn on Boost's page cache.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Note
Test this on a site using Endurance page cache. See HOG-96.
Alternatively, you can set
add_filter( 'jetpack_boost_compatibility_has_cache', '__return_true' );
in your testing environment to mock things.