Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Make OTel the preferred tracing plugin #35050

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

pvaneck
Copy link
Member

@pvaneck pvaneck commented Apr 3, 2024

This changes the order for which we try to use tracing plugins. Now, the OTel plugin will be checked first.

OpenCensus has been sunsetted and the recommendation has been to use OpenTelemetry for quite a while now.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link

github-actions bot commented Jun 7, 2024

Hi @pvaneck. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@pvaneck pvaneck force-pushed the core-default-tracing branch from fe49f3a to d1edeb5 Compare June 28, 2024 22:36
This changes the order for which we try to use tracing plugins. Now, the
OTel plugin will be checked first.

Signed-off-by: Paul Van Eck <[email protected]>
@pvaneck pvaneck force-pushed the core-default-tracing branch from d1edeb5 to 49bf149 Compare June 28, 2024 22:38
@pvaneck pvaneck marked this pull request as ready for review June 28, 2024 22:39
Copy link
Member

@johanste johanste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would even consider dropping implicit open census usage altogether. Let's open an issue and see if we can align the timing with other azure open census functionality/library support being dropped.

@pvaneck
Copy link
Member Author

pvaneck commented Jul 2, 2024

I would even consider dropping implicit open census usage altogether. Let's open an issue and see if we can align the timing with other azure open census functionality/library support being dropped.

Yep, can drop it with the deprecation of the opencensus plugin. I created a tracking issue: #36310

@pvaneck pvaneck merged commit 1d4fe36 into Azure:main Jul 2, 2024
239 checks passed
@pvaneck pvaneck deleted the core-default-tracing branch July 2, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants