Skip to content

Fix display of version #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 29, 2025
Merged

Fix display of version #336

merged 5 commits into from
Apr 29, 2025

Conversation

Alidra
Copy link
Member

@Alidra Alidra commented Apr 25, 2025 •
edited by fblanqui
Loading

This PR fixes the display of Dedukti version (#300) when called in command line (for instance dk --version)

@Alidra Alidra requested a review from fblanqui April 25, 2025 17:23
@Alidra Alidra linked an issue Apr 25, 2025 that may be closed by this pull request
dk --version does not work #300
Closed
@fblanqui
Copy link
Member

Thank you Abdelghani for your PR. Does dk --version alone works too?

fblanqui
fblanqui requested changes Apr 28, 2025
View reviewed changes
@Alidra
Copy link
Member Author

Alidra commented Apr 28, 2025

Thank you Abdelghani for your PR. Does dk --version alone works too?

Yes. It displays the same version as dk <anything> --version.
Actually, the version variable is not really useful in the sub commands.

@fblanqui fblanqui merged commit cf7dec1 into Deducteam:master Apr 29, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fblanqui fblanqui fblanqui requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dk --version does not work
2 participants
@Alidra @fblanqui