Add photo policy text #189
Conversation
octopusinvitro
force-pushed
the
add-photo-policy-text
branch
from
2dcad74 to
ab11a90
Compare
There was a problem hiding this comment.
I've put a couple of small requests for things to change inline.
The policy reads very slightly oddly to me, since the original text was aimed at reviewers rather than submitters, but I think it's fine at the moment, and it's a good idea for people submitting photos to know these guidelines anyway.
| @@ -1,3 +1,6 @@ | |||
| {% load i18n %} | |||
|
|
|||
| {% blocktrans trimmed %} | |||
There was a problem hiding this comment.
I think this is too big a block to have as a single unit for translation - and it would need care to deal with because it contains HTML tags. I'd mark these up separately with trans or blocktrans:
- "Photo policy"
- "The photo must be a clear, recent, colour headshot of the candidate."
- "No text or party logos may be included in the photo, unless an unavoidable part of the background or a small rosette/badge that doesn’t interfere with the rule above. Any photo containing party text or logos should be replaced by a plain photo whenever one is available."
mysite/templates/generic_base.html
Outdated
| @@ -155,7 +155,8 @@ | |||
| <p><a href="{% url 'help-api' %}">{% trans "Open data API" %}</a> | |||
| · <a href="{% url 'help-about' %}">{% trans "About" %}</a> | |||
| · <a href="https://github.com/DemocracyClub/yournextrepresentative/issues">{% trans "Issue tracker" %}</a> | |||
| · <a href="{% url 'help-privacy' %}">{% trans "Privacy policy" %}</a></p> | |||
| · <a href="{% url 'help-privacy' %}">{% trans "Privacy policy" %}</a> | |||
| · <a href="{% url 'help-photo-policy' %}">{% trans "Photo policy" %}</a></p> | |||
There was a problem hiding this comment.
I don't this this is imprant enough to include as a separate item in the footer, actually. Being linked to from the About page is fine.
octopusinvitro
force-pushed
the
add-photo-policy-text
branch
2 times, most recently
from
a09dc70 to
e327811
Compare
The text of the photo policy was extracted into its own file so that we can use it in several other pages on the site.
mhl
force-pushed
the
add-photo-policy-text
branch
from
e327811 to
28f1838
Compare
|
Looks good to me! 👍 (It made me laugh to see my Lego X-Wing pilot in this pull request...) |
|
Haha yeah, I was getting 404s so I just searched for photos and there was a foo, looking at me with its shiny eyes ✨ ... how could you not choose the poor foo as a foo image. How! |
|
I like that the photo doesn't pass the photo policy, too :) |
|
Thanks everyone. |
Relevant issues
Screenshots
The photo review already had a photo policy:
So a partial template was extracted with the text and added to the upload photo page as well:
A dedicated page was made for this policy so that it could be linked from the About page as issue 144 requires:
A link was added in the About page: