Skip to content

remove references to icsm #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove references to icsm #245

wants to merge 1 commit into from

Conversation

umma-zannat
Copy link
Collaborator

No description provided.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 14032630007

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 81.165%

Files with Coverage Reduction New Missed Lines %
dynadjust/dynadjust/dnaadjustwrapper/dnaadjustprogress.cpp 1 70.56%
Totals Coverage Status
Change from base Build 14032515927: 0.05%
Covered Lines: 32217
Relevant Lines: 39693

💛 - Coveralls

Copy link
Collaborator

@rogerfraser rogerfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Good to see a new docker repo created, thanks!
  • The new links to codacy and codecov badges and dashboards are broken, as explained. For now, revert to the icsm-au account.
  • All other changes have been tested and work successfully.

[![cii best practices](https://img.shields.io/badge/cii%20best%20practices-passing-success)](https://bestpractices.coreinfrastructure.org/projects/4894)
[![Coverage Status](https://coveralls.io/repos/github/GeoscienceAustralia/DynAdjust/badge.svg)](https://coveralls.io/github/GeoscienceAustralia/DynAdjust)
[![codecov status](https://img.shields.io/codecov/c/github/icsm-au/dynadjust)](https://codecov.io/gh/icsm-au/DynAdjust)
[![codecov status](https://img.shields.io/codecov/c/github/GeoscienceAustralia/dynadjust)](https://codecov.io/gh/GeoscienceAustralia/DynAdjust)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since GA doesn't have an account with codecov yet, this link (https://codecov.io/gh/GeoscienceAustralia/DynAdjust) will be broken. That's why this badge still points to icsm (https://codecov.io/gh/icsm-au/DynAdjust). I suggest leave as icsm-au for now.

[![docker build](https://github.com/icsm-au/DynAdjust/actions/workflows/docker.yml/badge.svg)](https://github.com/icsm-au/DynAdjust/actions/workflows/docker.yml)
[![codacy badge](https://img.shields.io/codacy/grade/a3944cda0c72445f8a13b1f82b64f714)](https://app.codacy.com/gh/icsm-au/DynAdjust/dashboard)
[![docker build](https://github.com/GeoscienceAustralia/DynAdjust/actions/workflows/docker.yml/badge.svg)](https://github.com/GeoscienceAustralia/DynAdjust/actions/workflows/docker.yml)
[![codacy badge](https://img.shields.io/codacy/grade/a3944cda0c72445f8a13b1f82b64f714)](https://app.codacy.com/gh/GeoscienceAustralia/DynAdjust/dashboard)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since GA doesn't have an account with codacy yet, this link (https://app.codacy.com/gh/GeoscienceAustralia/DynAdjust/dashboard) will be broken. That's why this badge still points to icsm (https://app.codacy.com/gh/icsm-au/DynAdjust/dashboard). I suggest leave as icsm-au for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants