COMP: Use future recommended code for remote modules with ITKv5.4.4 #5183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When preparing for the future with ITK by setting ITK_FUTURE_LEGACY_REMOVE:BOOL=ON ITK_LEGACY_REMOVEBOOL=ON The future preferred macro should be used │ - itkTypeMacro │ + itkOverrideGetNameOfClassMacro
These select remote modules are chosen to support the building of heavily used projects that depend on ITK. Slicer (https://github.com/Slicer/Slicer) BRAINSTools (https://github.com/BRAINSia/BRAINSTools) ANTs (https://github.com/ANTsX/ANTs) needs of remote modules for ITK. When preparing for the future with ITK by setting ITK_FUTURE_LEGACY_REMOVE:BOOL=ON ITK_LEGACY_REMOVEBOOL=ON Identifies code changes that will eventually be needed in future version (i.e. ITKv6 and ITKv7) once deprecated code is removed. By updating the following remote modules to be backward and future compatible with the recommended coding standards, we can more easily address code updates for supporting the community. Modules/Remote/AdaptiveDenoising.remote.cmake Modules/Remote/AnisotropicDiffusionLBR.remote.cmake Modules/Remote/GenericLabelInterpolator.remote.cmake Modules/Remote/GrowCut.remote.cmake Modules/Remote/IOScanco.remote.cmake Modules/Remote/MGHIO.remote.cmake Modules/Remote/MorphologicalContourInterpolation.remote.cmake Modules/Remote/RLEImage.remote.cmake Modules/Remote/SimpleITKFilters.remote.cmake Modules/Remote/SubdivisionQuadEdgeMeshFilter.remote.cmake
hjmjohnson
added
type:Compiler
github-actions
bot
added
type:Infrastructure
hjmjohnson
changed the title
|
Approach looks good. Most of the work will be in "greening" the remote modules. |
thewtex
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These selected remote modules are chosen to support
the building of heavily used projects that depend
on ITK.
Slicer (https://github.com/Slicer/Slicer)
BRAINSTools (https://github.com/BRAINSia/BRAINSTools)
ANTs (https://github.com/ANTsX/ANTs)
needs of remote modules for ITK.
When preparing for the future with ITK by setting
ITK_FUTURE_LEGACY_REMOVE:BOOL=ON
ITK_LEGACY_REMOVEBOOL=ON
Identifies code changes that will eventually be needed in
future version (i.e. ITKv6 and ITKv7) once deprecated
code is removed.
By updating the following remote modules to be backward and
future compatible with the recommended coding standards, we
can more easily address code updates for supporting the
community.
Pull requests that this one depends upon:
PR Checklist