Skip to content

fix(theme) adding space to template to preserve the intended display style without side effects #4921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

YashJM
Copy link
Contributor

@YashJM YashJM commented May 11, 2024

Prerequisites

  • I have read and understood the [contributing guide][CONTRIBUTING.md].
  • The commit message follows the [conventional commits][cc] guidelines.
  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been added/updated (for bug fixes / features).

Description

This pull request addresses an issue observed in [montys] theme, where the status character at the end of the rendered content was being truncated, The solution involved adjusting the template to include additional space, thereby allowing ample room for the character to render fully. This adjustment resolves the rendering issue and ensures the complete display of the status character.

Before change
image

image

After change
image

image

@JanDeDobbeleer JanDeDobbeleer merged commit 6177afd into JanDeDobbeleer:main May 13, 2024
30 of 31 checks passed
@JanDeDobbeleer
Copy link
Owner

@all-contributors please add @YashJM for design

This is pure magic 🪄! @holopin-bot @YashJM wizard

Copy link

holopin-bot bot commented May 13, 2024

Congratulations @YashJM, you just earned a badge! Here it is: https://holopin.io/claim/clw4l307926770fl1x43ps9fq

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Copy link
Contributor

@JanDeDobbeleer

I've put up a pull request to add @YashJM! 🎉

@YashJM
Copy link
Contributor Author

YashJM commented May 13, 2024

Thanks a lot @JanDeDobbeleer for reviewing and approving my PR! 🚀🚀

@JanDeDobbeleer
Copy link
Owner

Thanks for submitting a PR to the project!

In order to review and merge PRs most efficiently, we require that all PRs grant maintainer edit access before we review them. For information on how to do this, see the documentation.

1 similar comment
@JanDeDobbeleer
Copy link
Owner

Thanks for submitting a PR to the project!

In order to review and merge PRs most efficiently, we require that all PRs grant maintainer edit access before we review them. For information on how to do this, see the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants