Basic Plots #29
Open
Basic Plots #29
+41
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think it makes sense to use Plots instead of the superior Makie. |
|
Okk, let's use Makie then. Never used it before so didn't consider it 😄 . |
Datseris
reviewed
Jun 13, 2021
| @@ -37,7 +37,7 @@ export melspectrogram, mfcc | |||
| export spectrogram, stft, istft, phase_vocoder | |||
|
|
|||
| function __init__() | |||
| @require Plots = "91a5bcdd-55d7-5caf-9e0b-520d859cae80" include("display.jl") | |||
| @require GLMakie = "e9467ef8-e4e7-5192-8a1a-b1aee30e663a" include("display.jl") | |||
There was a problem hiding this comment.
Should I use Makie instead of GLMakie?
There was a problem hiding this comment.
okay for now use GLMakie. We will resolve this later.
|
Alright, I've been away from this project for a lot of time, sorry. Plotting functionality should be in MusicVisualizations.jl and not here though. (And yes, MusicVisualizations.jl would be updated to use Makie.jl also for MIDI-based plotting) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
Solves some issues for #28
This PR is supposed to cover:
Sample Spectrogram: