-
Notifications
You must be signed in to change notification settings - Fork 739
AP22913CN4-7 load switch #2864
base: master
Are you sure you want to change the base?
AP22913CN4-7 load switch #2864
Conversation
Hi @chmorgan , thanks for contributing, A few comments I have during my review:
The SOT-26 symbol is not the same, should be a different symbol. You can submit it in this PR or in another PR if you want. Cheers, |
I don't see any mention in the KLC about the regulator or control conventions around pin naming. I copied the convention used by the other power switches. For power management should the pins match the datasheet pin names? For regulators I take it they should always be IN and OUT even if it doesn't match the datasheet pin names? Chris |
@chmorgan thanks for the fixes, We try for all devices to have pin matching the datasheet. This is really better because this can trouble people later when using the symbol. Some exception (still valid) have been made for some very common regulators in which the datasheet pins names are "INPUT" and "OUTPUT". This is too much long and in this case we have preferred "IN" and "OUT" but this remains an exception. Joel |
Closing/opening to refresh the Travis test. |
@chmorgan two comments here:
Joel |
OnSemi load control switch
Footprint pull request: KiCad/kicad-footprints#2364
https://www.diodes.com/assets/Datasheets/AP22913.pdf
All contributions to the kicad library must follow the KiCad library convention
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:
Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.