feat(gwf): add ghba package #2247
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjreno
force-pushed
the
gwb_array
branch
3 times, most recently
from
fc10d2a to
21826ce
Compare
mjreno
force-pushed
the
gwb_array
branch
2 times, most recently
from
dd4351e to
2b1ac9b
Compare
added 11 commits
April 22, 2025 07:39
There was a problem hiding this comment.
Looks good to me, @mjreno. I have a few comments in there, but nothing major. Once you are satisfied, I think it can go in. Maybe leave as dev option for now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add array input package for General-Head Boundary:
- Dependent on modflowpy/flopy#2471, tests will be added after PR is merged
- Distinct from
EVTAandRCHAas input is fully gridded with no layer index array- No
READASARRAYSoption, model package block should specifically listGHBA6package type- Generic NetCDF read / write capability for layer and grid based package input
- NetCDF dynamic input for layer (
RCHA, EVTA) and grid (GHBA) array input packages stored as timeseries- The current thought is to release
GHBA,WELA,DRNA,RIVA, andCHDAtogether soGHBAwill be marked as a dev feature and doc updates will be withheld for now.ruffon new and modified python scripts in .doc, autotests, doc, distribution, pymake, and utils subdirectories.fprettifyFor additional information see instructions for contributing and instructions for developing.