ack messages earlier for improved performance and reliability #1430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results243 tests 238 ✅ 1m 35s ⏱️ For more details on these failures, see this check. Results for commit d3a8ab5. |
|
specific mention: #1411 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somebody had a complaint about the AMQP session dropping during long transfers... because it was idle while the transfers were going on.
One such discussion is #1411 ... where it talks about "a file transfer to take >60 seconds" where the real problem is that it will only ack any message in a batch after the entire batch has been attempted, which might take quite a while.
So with this change, each message is acknowledged individually ASAP, in download and send.