Skip to content

Fix syntax with logging #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Fix syntax with logging #4

merged 1 commit into from
Oct 10, 2022

Conversation

danbarke
Copy link
Contributor

@danbarke danbarke commented Oct 4, 2022

Some invocations of logging used the format:
logging.info.()
which includes and extra "." after info.
The correct logging line is:
logging.info()

Also remove logging from install_requires list. logging is part of the python standard library in python 3. An error is thrown when trying to install TRANSACT when logging is in the install_requires list.

Some invocations of logging used the format:
logging.info.()
which includes and extra "." after info.
The correct logging line is:
logging.info()

Also remove logging from install_requires list. logging is part of
the python standard library in python 3. An error is thrown when
trying to install TRANSACT when logging is in the install_requires
list.
@saroudant saroudant merged commit d0a9501 into NKI-CCB:main Oct 10, 2022
@saroudant
Copy link
Member

Hi @danbarke,
Thanks a lot for your commit and for spotting this mistake. I have merged the two versions.
Best regards,
Soufiane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants