Simplify the implementation of crypto::common.
#500
Closed
+5,179
−6,073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TransitioningNsecToNsec3, and TransitioningNsec3ToNsec.
Move parse_from_bind, format_as_bind, and display_as_bind to dnssec::common. Move key_size to dnssec::validator::base.
…plate code that just passes through to either Ring or OpenSSL, with the same logic as before that Ring will be used if both Ring and OpenSSL are enabled.
ximon18
changed the title
crypto::common.
|
Maybe this could even be done just via imports without the type definitions in this PR. |
|
This PR is a bit old now, not critical and probably out-dated. I'll close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By removing the boilerplate code that just passes through to either Ring or OpenSSL, with the same logic as before that Ring will be used if both Ring and OpenSSL are enabled.
I was triggered to try removing this boiler plate when I saw that all of the impls are just wrappers around either
super::ringorsuper::opensslfunctions with identical signatures.I haven't looked further at the
dnssec-restructurePR yet, this was the first thing I saw when starting to review it, so maybe this doesn't make sense for some reason I haven't thought of yet or due to something I haven't seen in that PR yet.