XFR processing fixes and improvements: #507
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- FIX: Also instruct the caller to delete all records when fallback from IXFR to AXFR is detected and add a test for this case. - Return an error if the caller attempts to process records if the end of the XFR has already been reached and add a test for this case. - Return an error if the first record of the XFR is not a SOA record. - Convert member fields that don't need to be public into private fields. - Don't use assert!(it.eq(..)) as it doesn't reveal which element didn't match.
ximon18
force-pushed
the
fix-ixfr-axfr-fallback-handling
branch
from
ac19b1c to
d1ee169
Compare
ximon18
added
breaking
…rade signal response.
ximon18
force-pushed
the
fix-ixfr-axfr-fallback-handling
branch
from
b664e5f to
fc8c92e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug and addresses some feature gaps in the
XfrResponseInterpreter.Note: As this PR adds variants to the
IteratorErrorenum it is a breaking change but only in code behind an unstable feature gate.