Remove incorrect logic for determining the apex from signing function. #521
+367
−233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, instead require the apex name to be passed in. This fixes issues such as signing wrongly identifying an out-of-zone name (such as a glue that sorts earlier than the zone) as the apex instead of the zone itself. Also update Rust Doc strings to more closely match current behaviour of the signing APIs.
… it doesn't belong in this PR.
| @@ -470,6 +486,10 @@ where | |||
| last_nent_stack.push(name.clone()); | |||
| } | |||
|
|
|||
| let Some(nsec3param_ttl) = nsec3param_ttl else { | |||
| return Err(SigningError::SoaRecordCouldNotBeDetermined); | |||
There was a problem hiding this comment.
Is this the wrong error here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead require the apex name to be passed in.
This fixes issues such as signing wrongly identifying an out-of-zone name (such as a glue that sorts earlier than the zone) as the apex instead of the zone itself.
Also update Rust Doc strings to more closely match current behaviour of the signing APIs.