Fix overflow for /0 #323
Merged
Fix overflow for /0 #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partim
approved these changes
Mar 27, 2025
partim
added a commit
that referenced
this pull request
Apr 23, 2025
New * Added support for ASPA to SLURM. ([#325], [#329]) Bug fixes * Fix access to flags in the ASPA and router key RTR PDUs. ([#327]) * Fix reported version in EndOfData RTR PDUs. ([#328]) * Fix an overflow in `AddressRange::to_vX_prefixes` for prefix length 0. ([#323]) Other changes * The minimum supported Rust version is now 1.81. ([#326])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it would make a prefix, add that to the start, and check whether the end is still smaller than the starting address. This can lead to situations where e.g. 0.0.0.0 - 255.255.255.255 would overflow, as it would try to go up to 256.0.0.0, which the u32 cannot contain.
These changes add a check for the last address to fix that.
(Relates to NLnetLabs/krill#1251)