Initial attempt to add ASPA SLURM support #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partim
reviewed
Mar 27, 2025
There was a problem hiding this comment.
The version only being checked in the FromStr impl is a bit problematic: When you are reading Slurm from a file, you are likely to use serde_json::from_reader which would bypass this check.
I think there is no way other than doing your own Serialize and Deserialize impls for SlurmFile.
|
Actually, it occurs to me now that for parsing, we can also not care. As long as it has the bits we expect, we might as well ignore the version number. |
partim
approved these changes
Apr 11, 2025
partim
added a commit
that referenced
this pull request
Apr 23, 2025
This PR makes the changes to SLURM in #325 non-breaking by removing the aspa argument from ValidationOutputFilters::new and LocallyAddedAssertions::new and setting the aspa fields of these structs initially to None. The braces constructor can be used to create fully populated values.
partim
added a commit
that referenced
this pull request
Apr 23, 2025
New * Added support for ASPA to SLURM. ([#325], [#329]) Bug fixes * Fix access to flags in the ASPA and router key RTR PDUs. ([#327]) * Fix reported version in EndOfData RTR PDUs. ([#328]) * Fix an overflow in `AddressRange::to_vX_prefixes` for prefix length 0. ([#323]) Other changes * The minimum supported Rust version is now 1.81. ([#326])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to add support for ASPA SLURM as defined in https://datatracker.ietf.org/doc/html/draft-ietf-sidrops-aspa-slurm-02
Main open issue is how to handle version 1 vs version 2.