-
Notifications
You must be signed in to change notification settings - Fork 10
Add presence detection using the firebase realtime database websocket #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
raindrift
wants to merge
7
commits into
PAIR-code:main
Choose a base branch
from
Plurality-Institute:raindrift/presence-detection
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
bb2c1de
Add presence detection using the firebase realtime database websocket
raindrift 96e00db
Add a basic test for the presence cloud function, update tsconfig to …
raindrift efd875b
Merge branch 'main' into raindrift/presence-detection
raindrift c7be2df
Rename publicId -> privateId in rtdb rules json
raindrift e6dd4b5
Merge branch 'raindrift/presence-detection' of github.com:Plurality-I…
raindrift 19986e5
Merge branch 'main' into raindrift/presence-detection
raindrift 25d4d62
connected profile property is optional for backwards-compat, agent pa…
raindrift File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
{ | ||
"rules": { | ||
"status": { | ||
"$experimentId": { | ||
"$privateId": { | ||
".read": "true", | ||
".write": "true" | ||
} | ||
} | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
import { | ||
ref, | ||
onValue, | ||
onDisconnect, | ||
set, | ||
serverTimestamp, | ||
} from 'firebase/database'; | ||
|
||
import {makeObservable} from 'mobx'; | ||
|
||
import {Service} from './service'; | ||
import {FirebaseService} from './firebase.service'; | ||
|
||
interface ServiceProvider { | ||
firebaseService: FirebaseService; | ||
} | ||
|
||
/** Tracks whether a participant is connected, using the firebase realtime database's websocket */ | ||
export class PresenceService extends Service { | ||
constructor(private readonly sp: ServiceProvider) { | ||
super(); | ||
makeObservable(this); | ||
} | ||
|
||
setupPresence(experimentId: string, participantPrivateId: string) { | ||
const statusRef = ref(this.sp.firebaseService.rtdb, `/status/${experimentId}/${participantPrivateId}`); | ||
|
||
const isOffline = { | ||
connected: false, | ||
last_changed: serverTimestamp(), | ||
}; | ||
|
||
const isOnline = { | ||
connected: true, | ||
last_changed: serverTimestamp(), | ||
}; | ||
|
||
onValue(ref(this.sp.firebaseService.rtdb, '.info/connected'), (snapshot) => { | ||
const isConnected = snapshot.val(); | ||
if (!isConnected) { | ||
return; | ||
} | ||
|
||
// Set the user's status in rtdb. The callback will reset it to online | ||
// if the user reconnects. | ||
onDisconnect(statusRef).set(isOffline).then(() => { | ||
set(statusRef, isOnline); | ||
}); | ||
}); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this make the db open to the public?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes this key open to the public, but you can only access records for known IDs. Since research participants are anonymous (from an auth perspective) there is no other way.
However, I notice that I misnamed that ID. So lemme go fix that...