Skip to content

Refactor experiment editor UI (layout, text fields) #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Conversation

vivtsai
Copy link
Collaborator

@vivtsai vivtsai commented May 8, 2025

Adjust experimenter editor UI to make fields easier to edit and agent configuration more streamlined, e.g., more optional fields hidden in accordions and dialogs, less clicking between panels.

Fixes #503, #434, #258

@vivtsai vivtsai requested a review from cjqian May 8, 2025 21:12
@vivtsai vivtsai marked this pull request as ready for review May 8, 2025 21:12
@cjqian
Copy link
Member

cjqian commented May 9, 2025

Some notes playing around with this:

  • Remind me - does "Limit cohort to maximum number of participants" just "lock" the cohort at that number automatically?

Experiment creation page:

  • Visual consistency: The "Enable prolific" checkbox conditionally brings down the relevant input; can the "Limit cohort to maximum number of participants" above have the same behavior to keep the page as clean as possible on default?
  • Bug: I was able to create an experiment with empty required fields (e.g. to reproduce - click "Enable prolific" and create. Might be worth checking on the validation logic?

Stage pages:

  • What are your thoughts on keeping name and description outside of the accordion, and having "Popup metadata" and "Progression settings" as separate accordions underneath (default to closed)?

Agent creation:

  • What happens if I save an experiment with a mediator without a chat stage? Could be confusing.

@vivtsai
Copy link
Collaborator Author

vivtsai commented May 9, 2025

@cjqian responses inline:

  • Remind me - does "Limit cohort to maximum number of participants" just "lock" the cohort at that number automatically?

Yes, it does. We can add a tooltip to help clarify maybe?

  • Visual consistency: The "Enable prolific" checkbox conditionally brings down the relevant input; can the "Limit cohort to maximum number of participants" above have the same behavior to keep the page as clean as possible on default?

If we were to hide the "cohort max participants" field, then it automatically disappears when you hit Backspace inside the field (because that sets the max participants to 0/null, which is jarring). That's why I changed it to just disabled when the checkbox isn't checked.

  • Bug: I was able to create an experiment with empty required fields (e.g. to reproduce - click "Enable prolific" and create. Might be worth checking on the validation logic?

That's WAI, but we can adjust validation logic if you'd like. Right now we don't have much validation logic so the "required" things are mainly to signal the user's attention. I can also take off the "required" from those fields for now.

  • What are your thoughts on keeping name and description outside of the accordion, and having "Popup metadata" and "Progression settings" as separate accordions underneath (default to closed)?

Yes, that change is actually pending! Just wanted to start moving the fields first :)

  • What happens if I save an experiment with a mediator without a chat stage? Could be confusing.

This is also pending - I'm thinking we can put a warning in (and also have a quick link from the mediator editing page to add a chat stage).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants