-
Notifications
You must be signed in to change notification settings - Fork 10
Refactor experiment editor UI (layout, text fields) #509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This fixes scrolling/editing issues that were present in pr-textarea.
…t panel in experiment editor
Some notes playing around with this:
Experiment creation page:
Stage pages:
Agent creation:
|
@cjqian responses inline:
Yes, it does. We can add a tooltip to help clarify maybe?
If we were to hide the "cohort max participants" field, then it automatically disappears when you hit Backspace inside the field (because that sets the max participants to 0/null, which is jarring). That's why I changed it to just disabled when the checkbox isn't checked.
That's WAI, but we can adjust validation logic if you'd like. Right now we don't have much validation logic so the "required" things are mainly to signal the user's attention. I can also take off the "required" from those fields for now.
Yes, that change is actually pending! Just wanted to start moving the fields first :)
This is also pending - I'm thinking we can put a warning in (and also have a quick link from the mediator editing page to add a chat stage). |
Adjust experimenter editor UI to make fields easier to edit and agent configuration more streamlined, e.g., more optional fields hidden in accordions and dialogs, less clicking between panels.
Fixes #503, #434, #258