Comparing 4.2 to 5 #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erved_word_size Address ORA-00923 error by quoting a reserved word "SIZE"
…warn-on-records-fetched-greater-than Add missing test case for record_fetched_greater_than config
…ecord connection adapters column, delegation in Active Record have not use …
…utoincrement Remove unused `table_with_autoincrement` table
Update 'foo'.to_xml(lambda { |options, key| options[:builder].b(key) })
to {foo: lambda { |options, key| options[:builder].b(key) }}.to_xml
Change the Hash.to_xml with a lamda example
Add missing period after sentence.
Update send_data documentation [ci skip]
Remove reference to unknown method `dirty?` in docs [ci skip]
Small typo on a method name:
`Arel::Visitors::VISITORS` was removed at rails/arel#412.
…was_removed Define `arel_visitor` method on all adapters
[ci skip]
That helper will return time zones for any country that tzdata knows about. So it will be much simpler for non-US people to list own country time zones in HTML selects or anywhere.
[ci skip] Added note on child class maintaining parent's queue adapter. [ci skip] Added note on child class maintaining parent's queue adapter. [ci skip] removed documentation for child class inheriting the queue adapter.
Added documentation for ActiveJob queue adapter for a specific job. [ci skip]
Remove unecessary comment
…engine-bin remove rails 4 specification in bin/rails for plugins [ci skip]
…ions_in_route_definitions Do not destructively mutate passed options hash in route definitions
Follow up to 1683410.
…ated_in_block Fix `test_blank_columns_created_in_block`
If the adapter supports indexes in create table, it generates SQL in one query.
Object#inspect recursively inspects instance variables, exposing all internal state, including sensitive internal cache objects. Override Cache#inspect to give a high-level summary that never interferes with concurrent cache writes.
When the token is generated by the form we were using the schema and host information while only using the path to compare if the action was the same. This was causing the token to be invalid. To fix this we use the same information to generate the token and check it. Fix rails#24257
Follow up to 98264a1
remove `empty?` from CHANGELOG [ci skip]
Fix small typo in Active Record Migrations documentation
- Removed duplicate entry for collection caching. - The entry was duplicate and the link to PR was also wrong. - Consolidated entries for `belongs_to` required by default.
…otes Release notes: Remove duplicate entries
The should make it easier for apps to rescue ActiveModel specific errors without the need to wrap all method calls with a generic rescue RangeError.
…rror Change RangeError to a more specific ActiveModel::RangeError
… solved on 1.12.x
Fix failing tests
Depend on bundler 1.11.2 on travis until bundle update discrepancy is solved on 1.12.x
Fix actionpack typos [ci skip]
This is an engine living in action_cable/engine.rb, convention is to call these things *::Engine. Looking at thi git history looks like the current *::Railtie was just an accident.
2.2.4 --> 2.2.5 2.3.0 --> 2.3.1
[ci skip]
Fix some typos in comments [ci skip]
Bump Ruby versions
Adding the `each` method is required for ensuring compatibility between Rails, and other Rack frameworks (like Sinatra, etc.), that are mounted within Rails, and wish to use its session tooling. Prior to this, there was an inconsistency between ActionDispatch::Request::Session and Rack::Session::Cookie, due to the absence of the `each` method. This should hopefully fix that error. :) For a full integration test with Sinatra and a standalone Rack application, you can check out the gist for that here: https://gist.github.com/maclover7/08cd95b0bfe259465314311941326470. Solves rails#15843.
Ensure compatibility between ActionDispatch::Request::Session and Rack
The to_yaml method is undefined when running the test as: $ ruby -I lib:test test/core_ext/string_ext_test.rb Doesn't fail when running rake test:isolated presumably because something else has required 'yaml' already.
These two tests are explicitly testing that to_time is returning times with the sytem timezone's UTC offset, therefore they will fail when running them with `ActiveSupport.to_time_preserves_timezone = true`.
Add to the matrix of Travis tests an entry that runs the Active Support tests when `ActiveSupport.to_time_preserves_timezone = true`.
…-modes Run Active Support tests in both `to_time` modes
Passing conditions to `#destroy_all` was deprecated in c82c5f8.
…stroy_all do not pass conditions to `#destroy_all` [ci skip]
After fb898e9, the `before_destroy` had some code that used SQL interpolation left over. Don't think we should promote that even if the values aren't directly from user input.
Remove extra space [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to visualize what has changed in ActionView form helpers