Add ability to label managedclusters... #87
Conversation
hack/ocm-minikube.sh
Outdated
| @@ -8,6 +8,9 @@ set -x | |||
| set -e | |||
| trap 'echo exit value: $?;trap - EXIT' EXIT | |||
|
|
|||
| # pre-requisites | |||
| which jq | |||
There was a problem hiding this comment.
@hatfieldbrian if you prefer a different means to test tool availability do let me know.
There was a problem hiding this comment.
I prefer POSIX's command -v, but which should work.
There was a problem hiding this comment.
jFYI, I had fixed this to command -v ... as shellcheck caught the same.
with their own minikube profile names. This also lines up with the ocm-ramen-samples and cluster names used in that repository. Additionally reduced mirror snapshot time to 2m from 5m to ease testing delays. Signed-off-by: Shyamsundar Ranganathan <[email protected]>
ShyamsundarR
force-pushed
the
label-test-clusters
branch
from
9bfe4f9 to
87d2a2f
Compare
| @@ -160,6 +163,8 @@ spoke_add() | |||
| # Error from server (InternalError): Internal error occurred: failed calling webhook "managedclustermutators.admission.cluster.open-cluster-management.io": the server is currently unable to handle the request | |||
| set -e | |||
| date | |||
| kubectl --context ${hub_cluster_name} patch managedclusters/${1} -p $(jq -cn --arg clname "$1" '{"metadata":{"labels":{"name":$clname}}}') --type=merge | |||
There was a problem hiding this comment.
This is also in the ramen script:
ramen/hack/ocm-minikube-ramen.sh
Line 98 in 2b8b96c
Based on its inclusion here I presume it is an OCM requirement, more so than a ramen one. And if so, I wonder why OCM does not do it. @BenamarMk any thoughts?
There was a problem hiding this comment.
OCM upstream does not do it yet, although this is how its placement works.
I did not notice it in the ramen deploy part (had not got that far). It is better in the ocm setup as this is an expectation from the OCM setup phase.
There was a problem hiding this comment.
issue tracker to address managedcluster labeling: open-cluster-management-io/multicloud-operators-subscription#16
| @@ -160,6 +163,8 @@ spoke_add() | |||
| # Error from server (InternalError): Internal error occurred: failed calling webhook "managedclustermutators.admission.cluster.open-cluster-management.io": the server is currently unable to handle the request | |||
| set -e | |||
| date | |||
| kubectl --context ${hub_cluster_name} patch managedclusters/${1} -p $(jq -cn --arg clname "$1" '{"metadata":{"labels":{"name":$clname}}}') --type=merge | |||
| date | |||
There was a problem hiding this comment.
I put the date commands in to measure how long wait-type commands take.
with their own minikube profile names.
This also lines up with the ocm-ramen-samples and
cluster names used in that repository.
Additionally reduced mirror snapshot time to 2m
from 5m to ease testing delays.
Signed-off-by: Shyamsundar Ranganathan [email protected]