[Autocomplete] Set selected options on text change #12916
Draft
+55
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanaldred11
force-pushed
the
ryan/update-autocomplete-examples
branch
from
c79ee31
to
758ebe9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
When the text changes to match or no longer match one of the
Autocompleteoptions, the checkmark is not added or removed from the list item. This behaviour was called it in a PR review and it turned out to be the same behaviour that was copied from the Polaris documentation.I made this change in admin-web and now I'm following up to update the Polaris documentation
WHAT is this pull request doing?
This PR adds functionality to the applicable
Autocompleteexamples in the Polaris documentationHow to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.mdwith documentation changes