Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] SpillableHashJoinProbeOperator memory consumption for building partition hash table #56813

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IHEII
Copy link
Contributor

@IHEII IHEII commented Mar 11, 2025

Why I'm doing:

Fixes #56491

SpillableHashJoinProbeOperator will take much memory to restore/rebuild the partition hash table when DoP is elevated. Although there is a Memory Resource Manager that could help to control the memory usage in SpillableHashJoinProbeOperators ( by limiting the size of selected partition to smaller than 2 * spill_mem_table_size ), Memory Resource Manager hasn't considered multi-operators.

Considering Q97 in TPC-DS, it will take about 3-4 GB to rebuild the partition hash table at a time

Memory is calculated as below:

56 (DoP) * 4 MB (size of the hash table in this case) * 16 (partition from build operator)) = 3.5 GB

This PR will introduce a config called spillHashJoinProbeOpMaxBytes to help reduce memory consumption when building the partition hash table by limiting memory usage across all probe operators.

What I'm doing:

Fixes #56491

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@IHEII IHEII requested a review from a team as a code owner March 11, 2025 10:23
@wanpengfei-git wanpengfei-git requested a review from a team March 11, 2025 10:23
@mergify mergify bot assigned IHEII Mar 11, 2025
@IHEII IHEII changed the title [Fix] SpillableHashJoinProbeOperator memory consumption for building partition hash table [BugFix] SpillableHashJoinProbeOperator memory consumption for building partition hash table Mar 11, 2025
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/qe/SessionVariable.java 1 1 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 21 / 21 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exec/pipeline/hashjoin/spillable_hash_join_probe_operator.cpp 17 17 100.00% []
🔵 be/src/exec/pipeline/hashjoin/spillable_hash_join_probe_operator.h 2 2 100.00% []
🔵 be/src/runtime/runtime_state.h 2 2 100.00% []

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spillable Hash Join Probe Operator may use much more memory than expected
3 participants