-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Estimate cardinality of multiple equivalent predicates using multi-column combined stats #56836
Open
stephen-shelby
wants to merge
1
commit into
StarRocks:main
Choose a base branch
from
stephen-shelby:estimate_multi_eq_pred_with_mcstats
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+463
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...core/src/main/java/com/starrocks/sql/optimizer/statistics/PredicateStatisticsCalculator.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/com/starrocks/sql/optimizer/statistics/StatisticsEstimateUtils.java
Show resolved
Hide resolved
41e4a88
to
2d8b9cf
Compare
8a1ee55
to
4d6cd6c
Compare
…using multi-column combined stats Signed-off-by: stephen <[email protected]>
4d6cd6c
to
c6fb081
Compare
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 112 / 114 (98.25%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
major changes:
without multi-columns stats
Sel(p1 ∧ p2 ∧ p3) = Sel(p1) × Sel(p2)^{1/2} × Sel(p3)^{1/4}
Multi-column combined statistics based:
S_mc = max(min(1/NDV, min_sel), prod_sel)
Where:
1/NDV is the selectivity based on multi-columns ndv
min_sel is the minimum selectivity among correlated columns
prod_sel is the product of individual column selectivities
added session variable:
cbo_use_correlated_predicate_estimate
if use decreasing formula for CE. default value is true.
Fixes #issue
#56358
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: