Simplify cmake by having a single binaryen library target #7238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of declaring a separate static library target for each subdirectory, declare a single binaryen library target up front and then add sources to it from each subdirectory. Requires updating the minimum cmake version to avoid policy errors.
kripken
reviewed
Jan 23, 2025
| # https://packages.ubuntu.com/bionic/cmake | ||
| cmake_minimum_required(VERSION 3.10.2) | ||
| # https://packages.ubuntu.com/focal/cmake | ||
| cmake_minimum_required(VERSION 3.16.3) |
There was a problem hiding this comment.
lgtm aside from this - I'm not sure what our policy is on bumping this version. Do we have a sense that practically all linux distros are using newer versions? (Focal is from 2020 so that sounds good)
There was a problem hiding this comment.
Our policy in practice so far has been to match the minimum version used by default on the distros used on Emscripten CI. This follows that policy AFAICT.
kripken
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of declaring a separate static library target for each
subdirectory, declare a single binaryen library target up front and then
add sources to it from each subdirectory.
Requires updating the minimum cmake version to avoid policy errors.