Editor: Restore starter content modal #69081
Open
+188
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
added
[Type] Enhancement
|
Size Change: +320 B (+0.02%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
Mamaduka
commented
Feb 6, 2025
Comment on lines
+125
to
+135
| <ToggleControl | ||
| __nextHasNoMarginBottom | ||
| checked={ showStartPatterns } | ||
| label={ __( 'Show starter patterns' ) } | ||
| help={ __( | ||
| 'Shows starter patterns when creating a new page.' | ||
| ) } | ||
| onChange={ ( newValue ) => { | ||
| setShowStartPatterns( newValue ); | ||
| } } | ||
| /> |
There was a problem hiding this comment.
I just duplicated the option from the Preferences modal. Compared to "Don't show me this modal", I like neutral labeling here.
Let me know if you prefer to change anything.
Mamaduka
requested review from
carolinan,
stokesman,
fabiankaegy and
t-hamano
carolinan
reviewed
Feb 7, 2025
|
It looks like the modal may be loading twice. I am not able to reproduce the same on 6.7.1 without Gutenberg. 6.7.1, this PR, Twenty Twenty-Four, Windows, Chrome: pattern-modal-25-02-07-0713.mp46.7.1, this PR, Twenty Twenty-Five, Windows, Firefox: pattern-modal-25-02-07-0732-firefox.mp4 |
|
If someone reduces the height of the browser, the footer (modal actions) is eventually below the |
Good catch. I think it's a conflict with the new default rendering mode. I had it disabled locally.
Do you mind sharing a screencast? I'm unable to reproduce it. |
|
I don't know why anyone would reduce it to this size. It doesn't behave the same if the width is narrow. pattern-modal-25-02-07-0910-height.mp4 |
|
Thanks for the screencast, @carolinan! It seems like a general issue with sticky footers and Modals. I can also reproduce the same behavior for the P.S. Strangely, I can't lower the browser window height that much on MacOS. I had to resort to DevTools for testing. Screencast
|
This issue can also be reproduced with the font library modal with a similar fixed footer. Could this be considered an edge case for now? Videob4dbd638a4b1162daab7cbf065b4006b.mp4When "Show starter patterns" is enabled, opening and closing the preferences modal causes the starter content to re-appear. This behavior does not occur with the modal in 6.7. Is there a way to fix this? Video3ee9158787b59be0709702109199bab8.mp4What do you think about adding a skip button? Because the pattern modal that appears when you create a custom template has a skip button. Details
|
It seems like a general problem with the Modal component. Let's mark it as an edge case for these modals rather than a blocker.
IIRC, the behavior is the same on WP 6.7. The
The "Skip" only closes the modal; it doesn't update user starter content preferences. I think changing preferences requires more explicit consent, which is hard to convey with the "Skip" button. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #68736.
Reverts #66836.
PR restores the starter content modal for newly created pages, reverts the Zoom Out mode assembler, and adds a preferences toggle to the modal footer.
Todos
Why?
See: #68736 (comment)
Testing Instructions
Using TT4 or TT5
Testing Instructions for Keyboard
Same.
Screenshots or screencast