Use str_contains instead of strpos

WordPress · Dec 21, 2023 · eaca180 · eaca180
1 parent 1ab89fd
commit eaca180
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/includes/Checker/Checks/Plugin_Readme_Check.php b/includes/Checker/Checks/Plugin_Readme_Check.php
@@ -102,9 +102,9 @@ private function check_default_text( Check_Result $result, string $readme_file,
 		$donate_link       = $parser->donate_link;
 
 		if (
-			in_array( 'tags', $tags, true )
-			|| strpos( $short_description, 'Here is a short description of the plugin.' ) !== false
-			|| strpos( $donate_link, '//example.com/' ) !== false
+			in_array( 'tag1', $tags, true )
+			|| str_contains( $short_description, 'Here is a short description of the plugin.' )
+			|| str_contains( $donate_link, '//example.com/' )
 		) {
 			$this->add_result_warning_for_file(
 				$result,

diff --git a/phpstan.neon.dist b/phpstan.neon.dist
@@ -19,5 +19,6 @@ parameters:
       message: '/^Function str_contains not found.$/'
       paths:
         - includes/Checker/Checks/Abstract_File_Check.php
+        - includes/Checker/Checks/Plugin_Readme_Check.php
         - includes/Traits/Find_Readme.php
         - includes/Traits/File_Editor_URL.php