vrrp: improve handling of duplicate address owner - this is invalid #2547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Quentin Armitage <[email protected]>
Signed-off-by: Quentin Armitage <[email protected]>
The VRRP RFCs assume that only one device is configured as the address owned for any VRID. keepalived has extended functionality which detects if two (or more) systems are configured as the address owner (this is completely invalid configuration). To avoid multiple systems acting as address owner, and hence all of them remaining in master mode, keepalived will reduce an address owner's priority to 254 if the other device configured as address owner does not go away. This commit restores the priority of a vrrp instance to 255 if it had reduced it to 254 to avoid multiple VRRP instances simultaneously advertising that they are the address owner. Signed-off-by: Quentin Armitage <[email protected]>
If a VRRP instance is configured as address owner and it detects another device also advertising it is the address owner, only initially reduce our priority if our primary IP address is lower than the other device's primary IP address. Signed-off-by: Quentin Armitage <[email protected]>
If a VRRP instance is configured as address owner and it detects another device also advertising it is the address owner, we don't reduce our priority if our primary IP address is higher than the other device's primary IP address. However, if the other system, with a lower primary IP address, won't reduce its priority (e.g. it is not a keepalived implementation), then we will reduce our priority after a suitable time. Signed-off-by: Quentin Armitage <[email protected]>
Signed-off-by: Quentin Armitage <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.