Skip running not idle vrrp scripts #2563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix for a bug introduced during refactoring thread functions in: e8e6401 "Thread functions return value is not used so make them void" When a vrrp script is to be run (initially or after specified interval), first it is checked if it's in IDLE state. If not a log message is printed informing about skipping run due to script being either running or timed out. However despite not being idle the code continues to run new script process. In heavily loaded systems this caused running multiple instances of vrrp script at the same time. This patch brings back missing return, which was lost during refactoring. Signed-off-by: Lukasz Wojciechowski <[email protected]>
|
@lukaszwojciechowski Many thanks for identifying this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for a bug introduced during refactoring thread functions in: #1626
When a vrrp script is to be run (initially or after specified interval), first it is checked if it's in IDLE state. If not a log message is printed informing about skipping run due to script being either running or timed out. However despite not being idle the code continues to run new script process.
In heavily loaded systems this caused running multiple instances of vrrp script at the same time.
This patch brings back missing return, which was lost during refactoring.