Handle updated vrrp_delayed_start and return (none) from inet_sockaddrtos() if address unspecified #2580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Quentin Armitage <[email protected]>
Previously if the address was unspecified the formatted address from the previous call was returned, rather than something indicating that there was no address. Signed-off-by: Quentin Armitage <[email protected]>
We can't do anything with them, and they are not usable, so we now wait until we are notified that the address is no longer tentative before we consider using it. Signed-off-by: Quentin Armitage <[email protected]>
If an existing base interface of a VMAC is renamed, delete the VMAC since the configure base interface no longer exists. When an existing interface is renamed to match the base interface for a VMAC for a VRRP instance, for IPv6 when the VMAC interface is created a link local address is added, so clear the NO_ADDRESS fault flag by calling try_up_instance(). For IPv4 we do not add an address to the VMAC when it is created, so will wait for notlink notifications of addresses on the base interface, which can then be added to be VMAC. Since 4c7a94a ("vrrp: Make VMAC IPv6 link local address mirror parent interface"), it was not called anymore when a IPv6 link-local was back on the VMAC interface. Fixes: 4c7a94a ("vrrp: Make VMAC IPv6 link local address mirror parent interface") Based on a patch signed-off-by: Louis Scalbert <[email protected]> Signed-off-by: Quentin Armitage <[email protected]>
keepalived was warning that using ipsets had been specified but iptables had not been specified, even if ipsets had not been specified. Signed-off-by: Quentin Armitage <[email protected]>
The git-commit.h included in a tar file was not the correct version if keepalived had not been built since the last commit. Signed-off-by: Quentin Armitage <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.