Skip to content

feat!: remove webpack from dependencies #1304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Nov 21, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
e681407
fix: remove webpack from dependencies
drujensen Nov 11, 2022
6258ec5
fix: linting issue
drujensen Nov 11, 2022
452abcc
fix: specs
drujensen Nov 12, 2022
a2cb409
fix: rollback default database
drujensen Nov 12, 2022
9d9bd9f
fix: specs
drujensen Nov 12, 2022
4b84d0c
refactor: minor adjustments
drujensen Nov 12, 2022
d2e2944
refactor: cleanup more tests
drujensen Nov 12, 2022
d3c12de
fix: base64 spec
drujensen Nov 12, 2022
90f16cd
refactor: avoid around_each for all specs
drujensen Nov 12, 2022
1388a82
fix: broken wrapper
drujensen Nov 12, 2022
47f5f2d
fix: fix REDIS_URL
drujensen Nov 12, 2022
f6864a1
fix: make github action match docker compose
drujensen Nov 12, 2022
a8c0f57
fix: remove old crystal version file
drujensen Nov 13, 2022
cb31061
fix: update missing template changes
drujensen Nov 14, 2022
f925b9c
Merge branch 'dj-remove-webpack' of github.com:amberframework/amber i…
drujensen Nov 14, 2022
bd53455
fix: forcefully add public assets
drujensen Nov 14, 2022
4c29b31
fix: remove cli from .gitignore
drujensen Nov 14, 2022
784572f
fix: use latest images
drujensen Nov 15, 2022
d046935
fix: remove nodejs from Dockerfile
drujensen Nov 15, 2022
2224b57
fix: remove node dependency
drujensen Nov 15, 2022
791bdf4
fix: restore filter
drujensen Nov 15, 2022
b982c6a
fix: missed in slang template
drujensen Nov 15, 2022
bc48ea0
fix: needs to be type module for ES6 support
drujensen Nov 15, 2022
fc0b60f
Remove garnet spec (#1306)
drujensen Nov 15, 2022
8fa407b
1227 fix layout equals false (#1307)
drujensen Nov 21, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: base64 spec
  • Loading branch information
drujensen committed Nov 12, 2022
commit d3c12de0cbd2f93e5d42358514749cb773e5f415
6 changes: 3 additions & 3 deletions spec/amber/controller/render_spec.cr
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,9 @@ module Amber::Controller
end

it "renders a form with a csrf tag" do
reuslt = RenderController.new(context).render_with_csrf
reuslt.should contain "<form"
reuslt.should contain "<input type=\"hidden\" name=\"_csrf\" value="
result = RenderController.new(context).render_with_csrf
result.should contain "<form"
result.should contain "<input type=\"hidden\" name=\"_csrf\" value="
end
end
end
Expand Down
5 changes: 4 additions & 1 deletion src/amber/pipes/csrf.cr
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,10 @@ module Amber
end

def real_session_token(context) : String
(context.session[CSRF_KEY] ||= Random::Secure.urlsafe_base64(TOKEN_LENGTH)).to_s
unless context.session[CSRF_KEY].is_a? String
context.session[CSRF_KEY] = Random::Secure.urlsafe_base64(TOKEN_LENGTH)
end
context.session[CSRF_KEY].as(String)
end
end

Expand Down