feat: [enterprise] add serviceAccount #465
Open
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: luis.costa <[email protected]>
Signed-off-by: luis.costa <[email protected]>
luismacosta
force-pushed
the
serviceAccount
branch
from
e2fece9 to
773c788
Compare
luismacosta
changed the title
|
Hi @luismacosta , Thanks for the contribution! I left a couple of comments. We'll also want to bump the chart version so linting and such will pass. |
Signed-off-by: luismacosta <[email protected]>
Signed-off-by: luis.costa <[email protected]>
Signed-off-by: luis.costa <[email protected]>
Signed-off-by: luismacosta <[email protected]>
chart version updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: [enterprise] add serviceAccount
@HN23 can you please review this PR?