Skip to content

Flip dict null_density in test utils #7475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

blaginin
Copy link
Contributor

@blaginin blaginin commented May 6, 2025

Rationale for this change

create_dict_from_values has a reversed null_desity logic. For example:

    let arr = create_string_array_with_len::<i32>(20, 0.0, 50); // will generate no nulls
    let dict = create_dict_from_values::<Int32Type>(200_000, 1.0, &arr); // will also generate no nulls

Are there any user-facing changes?

Yes

@github-actions github-actions bot added the arrow Changes to the arrow crate label May 6, 2025
@alamb alamb changed the title Flip dict null_density Flip dict null_density in test utils May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant