Add const MAX_OFFSET to OffsetSizeTrait #7478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dandandan
approved these changes
May 7, 2025
|
❤️ |
alamb
reviewed
May 7, 2025
| } | ||
|
|
||
| impl OffsetSizeTrait for i32 { | ||
| const IS_LARGE: bool = false; | ||
| const PREFIX: &'static str = ""; | ||
| const MAX_OFFSET: usize = i32::MAX as usize; |
There was a problem hiding this comment.
maybe it would make sense to add this as u64 rather than usize so it works on 32 bit platforms like wasm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #7474.
Rationale for this change
In native code it is useful to be able to write code generic over
OffsetSizeTraitand it would be useful to know the max offset as ausizewithout deriving it at runtimeWhat changes are included in this PR?
add
const MAX_OFFSET: usizetoOffsetSizeTraitAre there any user-facing changes?
No
No