GH-46310: [C++] Clean up -Wself-move warning #46311
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
WillAyd
commented
May 4, 2025
| @@ -412,11 +412,6 @@ class TestSmallStaticVector : public ::testing::Test { | |||
| IntVectorType<N> moved_moved_ints = std::move(moved_ints); | |||
| ASSERT_EQ(moved_moved_ints.size(), 5); | |||
| EXPECT_THAT(moved_moved_ints, ElementsAre(4, 5, 6, 7, 8)); | |||
|
|
|||
| // Move into itself | |||
There was a problem hiding this comment.
The cpp standard makes it so that standard library types that are self assigned like this exist in a valid but unspecified state, so I think testing the contents of this after a self move does not rely upon standard behavior.
See also https://stackoverflow.com/questions/68274999/is-it-allowed-to-self-move-an-object-in-c
github-actions
bot
added
awaiting committer review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This cleans up code that generates compiler warnings and relies on undefined behavior
What changes are included in this PR?
Removal of self-move in the test suite
Are these changes tested?
Yes
Are there any user-facing changes?
No