-
Notifications
You must be signed in to change notification settings - Fork 3.7k
GH-46355: [Python] Fix table.to_struct_array with an empty table #46357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
See also: |
|
237816c
to
cd0e002
Compare
cd0e002
to
e696376
Compare
e696376
to
cac55f9
Compare
cac55f9
to
03f330d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@github-actions crossbow submit -g python |
Revision: 03f330d Submitted crossbow builds: ursacomputing/crossbow @ actions-39637f523f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too, thanks! 👍
I have run Python extended builds, just in case. Lets wait for them to finish before merging.
The CI failures are unrelated. The Python 3.10 are related to the test_gdb.py issue: |
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 88815a1. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Rationale for this change
Currently
pyarrow.Table.to_struct_array
fails if table is empty, this PR fixes that. See issue #46355 for the reproducible example.What changes are included in this PR?
Check if table is empty and create an empty chunked array using table schema for the array type
Are these changes tested?
I added a test for that, it failed before I implemented the fix
Are there any user-facing changes?
No